Prevent useless link with pythonXX_d.lib in Debug mode #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when CMAKE_BUILD_TYPE was Debug, I had a configuration where the linker looked for pythonXX_d.lib instead of pythonXX.lib.
Usually, pybind11 prevents that (as shown here: pybind/pybind11#1295).
Unfornutaly in ncalloc.h, there are NumPy includes but not the pybind11 include which manages that.
That's why I suggest adding pybind11 include before NumPy includes to prevent that.
(debug python lib is not commonly installed and if debug lib is wanted, using Py_DEBUG directive will help)