Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change PSMove mouse button bindings #15860

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

future-figs
Copy link
Contributor

The current PSMove bindings activate the Select button whenever Mouse1+Mouse2 are pressed at once. This is problematic if Select brings up a menu or something (which is pretty likely), since this button combo gets pressed a lot, usually not on purpose.

For one example, see Child of Eden, where Select brings up the calibration screen and Trigger/Move shoot different projectiles. It's unplayable with the current bindings, since Mouse1 and Mouse2 are constantly getting pressed at the same time during gameplay.

In this PR, the middle mouse button now serves as a modifier (a "shift key"). It doesn't send any button-press on its own -- it just changes what the rest of the buttons do. This is much less prone to accidental combos.

Mapping with Mouse3 not pressed:

  • Mouse1 = Trigger
  • Mouse2 = Move
  • Mouse4 = Circle
  • Mouse5 = Cross

Mapping with Mouse3 pressed:

  • Mouse1 = Select
  • Mouse2 = Start
  • Mouse4 = Triangle
  • Mouse5 = Square

I also added a "Mouse9" key for consistency -- it's required now that Mouse3 doesn't bind to any buttons.

I can't be sure if this layout is ideal for every PSMove game, but until proper PSMove keybinding is implemented, this seems like a better default setup.

@Megamouse
Copy link
Contributor

There are no 9 buttons in cell.
Please either remove it or add a comment to the enum value.

@future-figs
Copy link
Contributor Author

Oh, my bad. I'll change back to just 8 mouse buttons and adjust the bindings.

@future-figs
Copy link
Contributor Author

Updated with all Mouse9 stuff reverted/removed.

The original setup didn't require any button combos from an 8-button mouse user (although the combos were still in effect). Since Mouse3 doesn't map to anything on its own now, this means that exactly one combo is unavoidable even with an 8-button mouse.

On the other hand, I have never seen such a mouse and I think it's much better to optimize for the common 5-button mouse.

@Megamouse Megamouse merged commit 8f51b09 into RPCS3:master Aug 2, 2024
6 checks passed
@scju
Copy link

scju commented Aug 7, 2024

In Time Crisis: Razing Storm I can't confirm the calibration even if I press Mouse3 and Mouse4 (=triangle).

image

@scju
Copy link

scju commented Aug 7, 2024

I don't know why, but it always seems to be on pattern (1), even when I've pressed Mouse3.

--
(1) Mapping with Mouse3 not pressed:

Mouse1 = Trigger
Mouse2 = Move
Mouse4 = Circle
Mouse5 = Cross

(2) Mapping with Mouse3 pressed:

Mouse1 = Select
Mouse2 = Start
Mouse4 = Triangle
Mouse5 = Square

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants