SPU: Utilize Operating System sleep in detected RCHCNT loop #15801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
added
CPU
Optimization
Megamouse
reviewed
Jul 16, 2024
rpcs3/Emu/Cell/SPULLVMRecompiler.cpp
Outdated
| @@ -3532,6 +3551,50 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator | |||
| } | |||
| } | |||
|
|
|||
| if (m_inst_attrs[(m_pos - m_base) / 4] == inst_attr::rchcnt_loop) | |||
There was a problem hiding this comment.
Suggested change
| if (m_inst_attrs[(m_pos - m_base) / 4] == inst_attr::rchcnt_loop) | |
| if (m_inst_attrs[(m_pos - m_base) / 4] == inst_attr::rchcnt_loop) |
There was a problem hiding this comment.
is there only a specific keyword (e.g. "Channel pattern loop") traced in the log file that we can search for to understand if the game is affected by this improvement? or are there also other keywords? which ones eventually
elad335
force-pushed
the
analyser
branch
3 times, most recently
from
8de4fd4
to
1a9d476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects perhaps less than 100 games, if no "Channel pattern loop" message appears then no affect on games.
Makes RCHCNT busy loops waiting for channel to be accessible with no side effects in games, use operating system sleep and thread notifications to save CPU time.