Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang][OpenMP] Make FlangRuntime offload use builtins vs. libc #176

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[flang][OpenMP] Make FlangRuntime offload use builtins vs. libc #176

merged 1 commit into from
Oct 9, 2024

Conversation

dpalermo
Copy link

@dpalermo dpalermo commented Oct 9, 2024 

- Allows offload regions that need _FortranAAssign on device to link without GPU libc support
- Fixes unresolved symbols: strlen, memcpy, memset, memmove by using builtins
- Also moved a couple RT_OFFLOAD_VAR_GROUP_BEGIN to pick up additional declarations used in offload regions (seen in build warnings)
- There are still more opportunities where std::mem* routines are called that could use Fortran::runtime::mem* instead but will hold off on more changes until this patch is more fully exercised

@dpalermo
[flang][OpenMP] Make FlangRuntime offload use builtins vs. libc
c216291 
    - Allows offload regions that need _FortranAAssign on device
      to link without GPU libc support
    - Fixes unresolved symbols: strlen, memcpy, memset, memmove
      by using builtins
    - Also moved a couple RT_OFFLOAD_VAR_GROUP_BEGIN to pick up
      additional declarations used in offload regions (seen in
      build warnings)
    - There are still more opportunities where std::mem* routines
      are called that could use Fortran::runtime::mem* instead
      but will hold off on more changes until this patch is more
      fully exercised
@ronlieb ronlieb merged commit 15949dd into amd-trunk-dev Oct 9, 2024
3 of 5 checks passed
@dpalermo dpalermo deleted the dp_flangrt_hostdev_builtins branch October 11, 2024 02:38
@dpalermo dpalermo mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronlieb ronlieb ronlieb approved these changes

@ergawy ergawy Awaiting requested review from ergawy

@agozillon agozillon Awaiting requested review from agozillon

@DominikAdamski DominikAdamski Awaiting requested review from DominikAdamski

@bcornille bcornille Awaiting requested review from bcornille

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpalermo @ronlieb