[Flang][OpenMP] PFT-based detection of target SPMD #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatrak
requested review from
ergawy,
agozillon,
DominikAdamski,
dpalermo and
kparzysz
skatrak
force-pushed
the
lower-spmd-check
branch
from
8ae2bbd
to
73fa09a
Compare
DominikAdamski
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
LGTM.
One nit: could you add test:
!$omp target teams
!$omp distribute parallel do
do i = 1, 100
A(i) = i
end do
!$omp end distribute parallel do
!$omp distribute parallel do
do i = 1, 100
B(i) = i
end do
!$omp end distribute parallel do
!$omp end target teams
This patch improves the fix in llvm#125 to detect target SPMD kernels during Flang lowering to MLIR. It transitions from a MLIR-based check to a PFT-based check, which is a more resilient alternative since the MLIR representation is in process of being built where it's being checked.
skatrak
force-pushed
the
lower-spmd-check
branch
from
73fa09a
to
4ea5257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the fix in #125 to detect target SPMD kernels during Flang lowering to MLIR. It transitions from a MLIR-based check to a PFT-based check, which is a more resilient alternative since the MLIR representation is in process of being built where it's being checked.