-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Programming model documentation #3432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the depth for Multi Grid picture. It's multiple grids, thus it should show the depth of gray rectangles called "Grid"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already portraied by having several Grids in the picture. The grids don't necessarily have to be of uniform size, so laying them on top of each other could be misleading
Co-authored-by: MKKnorr <MKKnorr@web.de>
Co-authored-by: MKKnorr <MKKnorr@web.de>
I took over this PR and fixed all the remarks I still had on the original PR, in a hopefully sensible manner, and will create new issues for the docs team for the rest @jujiang-del please review and merge in Gerrit when appropriate |
Merging to Gerrit |
Closing, as this has been upstreamed via gerrit. Thanks! |
This PR succeeds #3318 and builds on top of #3405, adds a single commit on top the doc reorg.