Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Programming model documentation #3432

Closed
wants to merge 10 commits into from

Conversation

MathiasMagnus
Copy link
Contributor

@MathiasMagnus MathiasMagnus commented Mar 18, 2024

This PR succeeds #3318 and builds on top of #3405, adds a single commit on top the doc reorg.

docs/data/understand/programming_model/cdna3_cu_dark.png Outdated Show resolved Hide resolved
docs/data/understand/programming_model/rdna3_cu.drawio Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/reference/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
docs/understand/programming_model.rst Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the depth for Multi Grid picture. It's multiple grids, thus it should show the depth of gray rectangles called "Grid"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already portraied by having several Grids in the picture. The grids don't necessarily have to be of uniform size, so laying them on top of each other could be misleading

@MKKnorr
Copy link

MKKnorr commented Apr 8, 2024

I took over this PR and fixed all the remarks I still had on the original PR, in a hopefully sensible manner, and will create new issues for the docs team for the rest

@jujiang-del please review and merge in Gerrit when appropriate

@jujiang-del
Copy link
Contributor

Merging to Gerrit
https://gerrit-git.amd.com/c/compute/ec/hip/+/1034056

@MKKnorr
Copy link

MKKnorr commented Apr 26, 2024

Closing, as this has been upstreamed via gerrit. Thanks!

@MKKnorr MKKnorr closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants