Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable pass #3462

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add flag to disable pass #3462

wants to merge 3 commits into from

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Sep 19, 2024

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (b57b1e4) to head (a608a08).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3462   +/-   ##
========================================
  Coverage    92.02%   92.02%           
========================================
  Files          508      508           
  Lines        20948    20951    +3     
========================================
+ Hits         19278    19281    +3     
  Misses        1670     1670           
Flag Coverage Δ
92.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
982023
Rate old
8f4609
Diff Compare
torchvision-resnet50 64 3,251.74 3,251.92 -0.01%
torchvision-resnet50_fp16 64 6,992.14 6,998.28 -0.09%
torchvision-densenet121 32 2,435.22 2,432.52 0.11%
torchvision-densenet121_fp16 32 4,106.55 4,099.88 0.16%
torchvision-inceptionv3 32 1,636.60 1,635.33 0.08%
torchvision-inceptionv3_fp16 32 2,735.44 2,739.96 -0.16%
cadene-inceptionv4 16 777.18 776.37 0.10%
cadene-resnext64x4 16 808.30 807.99 0.04%
slim-mobilenet 64 7,460.90 7,454.13 0.09%
slim-nasnetalarge 64 208.33 208.25 0.04%
slim-resnet50v2 64 3,435.49 3,434.40 0.03%
bert-mrpc-onnx 8 1,153.66 1,157.86 -0.36%
bert-mrpc-tf 1 313.48 315.65 -0.69%
pytorch-examples-wlang-gru 1 416.87 421.77 -1.16%
pytorch-examples-wlang-lstm 1 394.87 445.90 -11.45% 🔴
torchvision-resnet50_1 1 773.00 777.66 -0.60%
cadene-dpn92_1 1 400.23 402.10 -0.47%
cadene-resnext101_1 1 382.71 383.76 -0.27%
onnx-taau-downsample 1 344.70 345.21 -0.15%
dlrm-criteoterabyte 1 35.09 35.07 0.06%
dlrm-criteoterabyte_fp16 1 58.12 58.12 0.00%
agentmodel 1 7,736.17 7,818.98 -1.06%
unet_fp16 2 58.58 58.66 -0.13%
resnet50v1_fp16 1 1,029.06 927.13 10.99% 🔆
resnet50v1_int8 1 931.63 935.97 -0.46%
bert_base_cased_fp16 64 1,153.62 1,154.27 -0.06%
bert_large_uncased_fp16 32 356.01 355.93 0.02%
bert_large_fp16 1 214.08 214.22 -0.07%
distilgpt2_fp16 16 2,163.63 2,163.12 0.02%
yolov5s 1 535.46 537.49 -0.38%
tinyllama 1 43.46 43.49 -0.06%
vicuna-fastchat 1 166.45 173.51 -4.07% 🔴
whisper-tiny-encoder 1 417.85 417.99 -0.03%
whisper-tiny-decoder 1 430.77 425.01 1.35%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@@ -40,6 +40,13 @@ inline namespace MIGRAPHX_INLINE_NS {

MIGRAPHX_DECLARE_ENV_VAR(MIGRAPHX_TRACE_PASSES);
MIGRAPHX_DECLARE_ENV_VAR(MIGRAPHX_TIME_PASSES);
MIGRAPHX_DECLARE_ENV_VAR(MIGRAPHX_DISABLE_PASSES);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the docs/dev/env_vars.rst to describe what this is does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants