Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waive sshd_use_approved_ciphers #215

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

jan-cerny
Copy link
Contributor

With the new productization model, these items also started to appear for a "Per Rule" test /per-rule/13/oscap/sshd_use_approved_ciphers/ which runs Automatus test.

See ComplianceAsCode/content#12096

With the new productization model, these items also started to
appear for a "Per Rule" test /per-rule/13/oscap/sshd_use_approved_ciphers/
which runs Automatus test.

See ComplianceAsCode/content#12096
Copy link
Contributor

@mildas mildas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You miss condition for waiver applicability and thus waiver syntax check failed.

conf/waivers/10-unknown Outdated Show resolved Hide resolved
Co-authored-by: Milan Lysonek <milan.lysonek@gmail.com>
@mildas mildas merged commit 5009840 into RHSecurityCompliance:main Jul 3, 2024
3 checks passed
@comps
Copy link
Contributor

comps commented Jul 3, 2024

This PR removes the empty line between /per-rule and the newly added waivers, making them seem related. Not sure that was a good idea, but probably not a big deal - we can fix the formatting in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants