Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Clients is used if it is set #1266

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Attribute Clients is used if it is set #1266

merged 5 commits into from
Sep 10, 2024

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Aug 20, 2024

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

#1264

  • What is the new behavior (if this is a feature change)?

Setting the Clients attribute uses the selected values if it evaluates to true.
Otherwise defaults are used.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@sidey79 sidey79 linked an issue Aug 20, 2024 that may be closed by this pull request
@sidey79 sidey79 self-assigned this Aug 20, 2024
@sidey79 sidey79 added the bug label Aug 20, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (c940a2d) to head (be31bfc).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
FHEM/00_SIGNALduino.pm 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
- Coverage   71.53%   70.95%   -0.58%     
==========================================
  Files         138      137       -1     
  Lines       10215    10226      +11     
  Branches     1602     1602              
==========================================
- Hits         7307     7256      -51     
- Misses       1575     1636      +61     
- Partials     1333     1334       +1     
Flag Coverage Δ
fhem 61.63% <94.73%> (-0.67%) ⬇️
modules 70.95% <94.73%> (-0.58%) ⬇️
perl 88.92% <ø> (ø)
unittests 70.95% <94.73%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sidey79 sidey79 changed the title Sidey79/issue1264 Attribute Clients is used if it is set Sep 9, 2024
@sidey79 sidey79 merged commit 23a7ef4 into master Sep 10, 2024
16 checks passed
@sidey79 sidey79 deleted the sidey79/issue1264 branch September 10, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set Clients attribute
3 participants