-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add circuit_depth
#454
base: master
Are you sure you want to change the base?
add circuit_depth
#454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a test?
Interface question, should |
Yes I think it should be a keyword argument since it's an option, thanks! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 88.28% 88.35% +0.06%
==========================================
Files 77 77
Lines 4824 4835 +11
==========================================
+ Hits 4259 4272 +13
+ Misses 565 563 -2
☔ View full report in Codecov by Sentry. |
need to fix the test and make sure it passes the CI, please let me know if you have issues with that |
yes sure |
Thanks for the pull request, but I think the depth counting should be implemented in a recursive style. You should add a test with the following circuit: chain(chain(put(4, 2=>X), control(4, 2, 3=>Z))) Its depth should be 2. Please refer the implementation of |
Fixes #426