move some utilities in YaoExtensions to Yao.EasyBuild submodule. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 80.02% 80.02%
=======================================
Files 68 68
Lines 3524 3524
=======================================
Hits 2820 2820
Misses 704 704 Continue to review full report at Codecov.
|
Roger-luo
reviewed
Dec 9, 2021
Roger-luo
approved these changes
Dec 16, 2021
| A general single qubits gate: ``e^(iϕ)R_z(θ_3)R_y(θ_2)R_z(θ_1)``. | ||
| Leave `ϕ` as `nothing` to fix the global phase. | ||
| """ | ||
| function general_U2(θ1, θ2, θ3; ϕ=nothing) |
There was a problem hiding this comment.
should this just be a block? this is also needed to map to openQASM etc.
There was a problem hiding this comment.
It sounds good, but let us do it in another PR. Let us convert your comment to an issue?
This was referenced Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some blocks and circuit builders.
List of blocks
List of shortcuts
cphaseandCPhaseGateList of circuits
List of hamiltonians
NOTE 1: they are not exported to the global scope, one has to type
to access these features in Yao's submodule.
NOTE 2: the reason why some blocks are not added
It does not mean other blocks are useful, will consider removing them in the future, they are in the deleting list. When a block can be replace by a combination of other blocks, I prefer not creating a new type except there is a practical using case.