Heatmap layer #24
Merged
Heatmap layer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nour-Cheour10
force-pushed
the
HeatmapLayer
branch
4 times, most recently
from
8901e3e
to
cd8f952
Compare
Nour-Cheour10
force-pushed
the
HeatmapLayer
branch
from
01538d1
to
e745023
Compare
|
update galata references |
|
update galata references |
martinRenou
reviewed
Jun 27, 2024
|
|
||
| this.map_container = document.createElement('div'); | ||
| this.map_container.classList.add('ol-container'); | ||
| requestAnimationFrame(() => { |
There was a problem hiding this comment.
It's unclear to me why we need a requestAnimationFrame here, what was the reason for adding it?
There was a problem hiding this comment.
I was trying to get the parentelement with this : this.el.parentElement but it was returning null at first, So I added requestAnimationFrame to give it more time to get executed and to get the right answer.
There was a problem hiding this comment.
This is odd, the zoom control shows up but not the tile layer. I wonder if we should not sleep a tiny bit of time before doing the screenshot
There was a problem hiding this comment.
Okay I'll add it
Co-authored-by: martinRenou <martin.renou@gmail.com>
Nour-Cheour10
force-pushed
the
HeatmapLayer
branch
from
336925e
to
ac5a0ab
Compare
|
update galata references |
martinRenou
requested changes
Jul 1, 2024
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.