-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 and bump rustworkx
to 0.13.2
#990
Conversation
Pull Request Test Coverage Report for Build 6392250583
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider dropping python 3.7 from CI beside adding python 3.12?
No, we supported 3.7 in the 0.13.x series and we’ll keep supporting it. It’s already dropped for 0.14 and onwards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, two questions inline but nothing major. The other thing is we probably need to do a cargo build
and update the Cargo.lock
because rustworkx and rustworkx-core are still at 0.13.1 in the lock file. The other thing is do you want to tag this PR as the 0.13.2, if so we probably should include a release note that notes that this release adds preliminary 3.12 support on top of 0.13.1.
@@ -57,7 +57,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
rust: [stable] | |||
python-version: ['3.7.16', 3.8, 3.9, "3.10", "3.11"] | |||
python-version: ['3.7.16', 3.8, 3.9, "3.10", "3.11", "3.12.0-rc.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'll have to wait a little bit for the default gha image to get 3.12.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not in https://github.com/raw/actions/python-versions/main/versions-manifest.json, but the ABI should be identical to the released one
I added a very brief release note for 0.13.2. So I think we should be able to tag this with 0.13.2 for the release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick updates
Oh, actually before we release this we'll need to update cibuildwheel in wheel builds to a newer version that includes 3.12 support |
In order to build Python 3.12 wheels on release we need to use a newer version of cibuildwheel. This commit bumps cibuildwheel to the latest release 2.16.1 which includes building Python 3.12 wheels by default using 3.12.0rc3.
Can you tag this commit as 0.13.2? I don't have the permission |
Start the work to support #986:
Because this updates PyO3, I think it should trigger a minor version bump to 0.13.2. In the release notes, we can be clear this has little to no change for 0.13.1 users running Python 3.11 or earlier.