Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stestr >= 4.1 #983

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Make stestr >= 4.1 #983

merged 1 commit into from
Sep 19, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #982

Make stestr have version greater than 4.1, containing the fix we need

@IvanIsCoding IvanIsCoding marked this pull request as ready for review September 18, 2023 22:49
@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Sep 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6228840647

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.491%
Totals Coverage Status
Change from base Build 6192538211: 0.0%
Covered Lines: 15400
Relevant Lines: 15960
💛 - Coveralls

mtreinish
mtreinish approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not strictly required this way because pip will install the latest of everything for us by default. But this doesn't hurt either so lets go for it

@mergify mergify bot merged commit b7c4081 into Qiskit:main Sep 19, 2023
27 checks passed
@IvanIsCoding IvanIsCoding deleted the fix-stestr branch September 30, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate stestr breaking
3 participants
@IvanIsCoding @coveralls @mtreinish