-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has path #952
Merged
Merged
Has path #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5758489008
💛 - Coveralls |
IvanIsCoding
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just removing some details from internals on docstrings as we probably should have options for different algorithms in the future. Also, I simplified the tests a bit
IvanIsCoding
reviewed
Aug 4, 2023
raynelfss
pushed a commit
to raynelfss/rustworkx
that referenced
this pull request
Aug 10, 2023
* Added has_path for PyGraph and PyDiGraph * Fixed linting errors and added release notes * Fixed doc type * Fixed cargo fmt problem * Fixed clippy problem * Typo in release notes * Apply suggestions from code review * Remove whitespace --------- Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #934.
Added a function
has_path()
which usesgraph_dijkstra_shortest_paths()
ordigraph_dijkstra_shortest_paths()
to check if a path between a source and target node exists for aPyGraph
orPyDiGraph
, respectively.