Adding Clippy Fix (backport #930) and Pin pillow<10 in CI (backport #922) #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://github.com/avatars/in/10562?s=60&v=4){kind=small}
Because of a new Rust update, Clippy now warned for a line of code in cycle_basis.rs in rustworkx-core. This PR fixes that one line so that Clippy passes. (cherry picked from commit d88f18b)
mtreinish
approved these changes
Jul 17, 2023
Pull Request Test Coverage Report for Build 5577769546
💛 - Coveralls |
Since the recent release of Pillow 10.0.0 the docs CI job has started failing due to an error in Pillow when trying to run the jupyter-execute cell in the `.to_dot()` docstring. It looks like a bug that was introduced in the new release which is being tracked in python-pillow/Pillow#7259 where it's trying to return a jpeg representation of the object from the RGBA data loaded from a PNG. Until the issue is resolved upstream in pillow this commit just caps the version we run in CI via the constraints file. While pillow is an optional dependency and we could cap the version in the extras, this issue isn't severe enough to warrant that, and the typical pillow usage, especially via the rustworkx api (i.e. graphviz_draw() which returns a PIL.Image object) will continue to work as expected with pillow 10.0.0 there isn't a reason to cap more broadly. This is just needed as a workaround to unblock CI.
mtreinish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #930 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com