Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraints in rustworkx-core for hashbrown and indexmap #929

Merged
merged 4 commits into from
Jul 20, 2023

Commits on Jul 14, 2023

  1. Relax constraints in rustworkx-core for hashbrown and indexmap

    This commit updates the version constraints on the hashbrown and
    indexmap dependencies in rustworkx-core's dependency list. These 2
    dependencies are used for I/O to rustworkx-core and we previously had
    our versions set to the highest version compatible with the msrv.
    However, for users of rustworkx-core with newer MSRVs this limited
    version support caused issues if they wanted to use a newer version of
    these library (which was compatible with their MSRV) as an input or output
    to rustworkx-core. For example, as described in Qiskit#911 qiskit-terra was
    using hashbrown 0.13.x and had errors because the released version of
    rustworkx-core only was listed as compatible with hashbrown 0.12. This
    version mismatch meant that the hashbrown objects created in
    qiskit-terra were not recognized by rustworkx-core because of the
    version mismatch. This commit attempts to fix this issue by increasing
    the allowable range of versions to be greater than or equal to our
    previous fixed version and capped at the last known working version.
    This should enable users to set a fixed library version that they want
    even if it's newer and requires a higher MSRV.
    
    This commit is for the stable/0.13 branch as the minimum version is
    lower on the stable branch as the MSRV for the 0.13.0 is much older than
    what we're using on the main branch now. A separate PR will be pushed up
    for main to update it there. This was done in reverse in the interest of
    ensuring we include this in 0.13.1 and the inevitable backport conflict
    if we started with main first.
    
    Fixes Qiskit#911
    mtreinish committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c8b5db5 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    e5e9d51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2237fe3 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    3b98a8f View commit details
    Browse the repository at this point in the history