Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.64 for 0.14.0 #910

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Bump MSRV to 1.64 for 0.14.0 #910

merged 5 commits into from
Jun 23, 2023

Conversation

mtreinish
Copy link
Member

This commit raises the MSRV for rustworkx and rustworkx-core to 1.64. Previously we had been matching the version of rust included with the latest debian stable release, which is 1.63 right now. However, some of our dependencies in rustworkx's latest release has bumped their msrv to 1.64 and instead of waiting for the next debian release it's probably better to just bump to 1.64. Installing newer versions of rust are something more users are accustomed to at this point so the need for debian compatibility isn't as important as it used to be.

This commit raises the MSRV for rustworkx and rustworkx-core to 1.64.
Previously we had been matching the version of rust included with the
latest debian stable release, which is 1.63 right now. However, some of
our dependencies in rustworkx's latest release has bumped their msrv to
1.64 and instead of waiting for the next debian release it's probably
better to just bump to 1.64. Installing newer versions of rust are
something more users are accustomed to at this point so the need for
debian compatibility isn't as important as it used to be.
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's time to bump the MSRV

docs/source/install.rst Outdated Show resolved Hide resolved
src/dag_algo/longest_path.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5359489448

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 96.41%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 1 98.54%
Totals Coverage Status
Change from base Build 5333537727: -0.05%
Covered Lines: 14905
Relevant Lines: 15460

💛 - Coveralls

@mtreinish mtreinish merged commit 20b2f55 into Qiskit:main Jun 23, 2023
24 checks passed
@mtreinish mtreinish deleted the msrv14 branch June 23, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants