Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply wheel job fixes from 0.13.0 release #896

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

mtreinish
Copy link
Member

This commit applies the various fixes needed to the wheel publishing job definitions for the 0.13.0 release. There were several jon errors during the release which were caused by various changes made to rustworkx, upstream dependencies, and CI environment since the 0.12.0 which caused issues during the release process. #753 should still be finished to simplify the job definitions, but that should be rebased to take this more targeted fix. The intent is for this to be a minimal diff for backporting to stable/0.13 for a future 0.13.1 release.

Of particular importance here though is the change in support tier for s390x from 3 to 4. This was caused by repeated issues with timeouts caused by running tests during the s390x linux wheel builds. To ensure we can reliably build the wheels this drops the testing from the s390x so that they can reliably complete in 12 job hours.

This commit applies the various fixes needed to the wheel publishing job
definitions for the 0.13.0 release. There were several jon errors during
the release which were caused by various changes made to rustworkx,
upstream dependencies, and CI environment since the 0.12.0 which caused
issues during the release process. Qiskit#753 should still be finished to
simplify the job definitions, but that should be rebased to take this
more targeted fix. The intent is for this to be a minimal diff for
backporting to stable/0.13 for a future 0.13.1 release.

Of particular importance here though is the change in support tier for
s390x from 3 to 4. This was caused by repeated issues with timeouts
caused by running tests during the s390x linux wheel builds. To ensure
we can reliably build the wheels this drops the testing from the s390x
so that they can reliably complete in 12 job hours.
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Jun 8, 2023
@coveralls
Copy link

coveralls commented Jun 8, 2023

Pull Request Test Coverage Report for Build 5294202048

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 96.46%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 1 98.88%
rustworkx-core/src/connectivity/all_simple_paths.rs 3 97.44%
Totals Coverage Status
Change from base Build 5291603092: 0.007%
Covered Lines: 15042
Relevant Lines: 15594

💛 - Coveralls

@mtreinish mtreinish added this to the 0.13.1 milestone Jun 9, 2023
Copy link
Contributor

@enavarro51 enavarro51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one in-line change. Also there seem to be some Mac changes. Are these required for this, or is this just some updating that needs to be done?

releasenotes/notes/s390x-tier-4-1701a0f044759cd1.yaml Outdated Show resolved Hide resolved
Co-authored-by: Edwin Navarro <enavarro@comcast.net>
@mtreinish
Copy link
Member Author

The two mac updates I made are to update the arm64 wheel jobs to use the macos-latest job image. During the 0.13.0 release this job failed because the macos-10.15 image it was trying to use no longer exits so it was waiting forever to get a VM allocated. The second update was just a small oversight in the supported platform docs, we have support for arm64 macOS and that just wasn't mentioned in the intro to supported platforms. I changed it in this PR because I already had to update to the docs to downgrade the s390x support tier to 4.

@enavarro51
Copy link
Contributor

LGTM. Thanks.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jun 16, 2023
@mergify mergify bot merged commit 8720cd3 into Qiskit:main Jun 16, 2023
29 checks passed
mergify bot pushed a commit that referenced this pull request Jun 16, 2023
* Apply wheel job fixes from 0.13.0 release

This commit applies the various fixes needed to the wheel publishing job
definitions for the 0.13.0 release. There were several jon errors during
the release which were caused by various changes made to rustworkx,
upstream dependencies, and CI environment since the 0.12.0 which caused
issues during the release process. #753 should still be finished to
simplify the job definitions, but that should be rebased to take this
more targeted fix. The intent is for this to be a minimal diff for
backporting to stable/0.13 for a future 0.13.1 release.

Of particular importance here though is the change in support tier for
s390x from 3 to 4. This was caused by repeated issues with timeouts
caused by running tests during the s390x linux wheel builds. To ensure
we can reliably build the wheels this drops the testing from the s390x
so that they can reliably complete in 12 job hours.

* Fix docs

* Update releasenotes/notes/s390x-tier-4-1701a0f044759cd1.yaml

* Update releasenotes/notes/s390x-tier-4-1701a0f044759cd1.yaml

Co-authored-by: Edwin Navarro <enavarro@comcast.net>

---------

Co-authored-by: Edwin Navarro <enavarro@comcast.net>
(cherry picked from commit 8720cd3)
enavarro51 pushed a commit that referenced this pull request Jun 17, 2023
* Apply wheel job fixes from 0.13.0 release

This commit applies the various fixes needed to the wheel publishing job
definitions for the 0.13.0 release. There were several jon errors during
the release which were caused by various changes made to rustworkx,
upstream dependencies, and CI environment since the 0.12.0 which caused
issues during the release process. #753 should still be finished to
simplify the job definitions, but that should be rebased to take this
more targeted fix. The intent is for this to be a minimal diff for
backporting to stable/0.13 for a future 0.13.1 release.

Of particular importance here though is the change in support tier for
s390x from 3 to 4. This was caused by repeated issues with timeouts
caused by running tests during the s390x linux wheel builds. To ensure
we can reliably build the wheels this drops the testing from the s390x
so that they can reliably complete in 12 job hours.

* Fix docs

* Update releasenotes/notes/s390x-tier-4-1701a0f044759cd1.yaml

* Update releasenotes/notes/s390x-tier-4-1701a0f044759cd1.yaml

Co-authored-by: Edwin Navarro <enavarro@comcast.net>

---------

Co-authored-by: Edwin Navarro <enavarro@comcast.net>
(cherry picked from commit 8720cd3)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants