Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement substitute_node_with_subgraph to Pygraph #894

Merged
merged 14 commits into from
Jun 20, 2023

Conversation

raynelfss
Copy link
Contributor

TO-DO:

  • Extend documentation.
  • Further testing.

@coveralls
Copy link

coveralls commented Jun 8, 2023

Pull Request Test Coverage Report for Build 5323382468

  • 92 of 96 (95.83%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/graph.rs 92 96 95.83%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 1 98.54%
rustworkx-core/src/connectivity/find_cycle.rs 3 94.34%
Totals Coverage Status
Change from base Build 5323364408: -0.01%
Covered Lines: 15133
Relevant Lines: 15690

💛 - Coveralls

Copy link
Contributor

@enavarro51 enavarro51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. It's looking good. A few in-line comments and if you add the docs, you can un-draft it.

src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
@raynelfss raynelfss marked this pull request as ready for review June 19, 2023 15:11
Copy link
Contributor

@enavarro51 enavarro51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@enavarro51 enavarro51 merged commit 8aa5289 into Qiskit:main Jun 20, 2023
27 checks passed
@raynelfss raynelfss deleted the pygraph_node_subgraph branch June 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PyGraph.substitute_node_with_subgraph() method
3 participants