-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy documentation in qiskit.org/ecosystem #843
Conversation
Pull Request Test Coverage Report for Build 4553753463
💛 - Coveralls |
I'm not sure I follow this step, is the plan you're doing to centralize the building of the redirects and remove the excludes here?: https://github.com/Qiskit/qiskit/blob/master/tools/other-builds.txt#L10 I assumed the plan was that we'd upload a redirect pages to |
Yes. My plan was to redirect |
updating initial comment to talk about CDN instead of metapackage. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I'm thinking we should also remember to add the CDN edge function redirect for retworkx -> rustworkx too while we're updating it.
Similar to Qiskit/qiskit-aer#1748, see Qiskit/qiskit.org#3038 for more context
Summary
The Qiskit Ecosystem lives in qiskit.org/ecosystem and new place for qiskit related projects that are not technically Qiskit. This PR adds that destination for documentation deployment.
Details and comments
For now, a copy of the same docs in ecosystem would allow to have both q.o/documentation and q.o/ecosystem for testing that everything is fine. Once that's done, the CDN will redirects to the new location and the deploy to q.o/documentation can be removed.