Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement check_cycle in __getstate__ and __setstate__. Expand python copy tests. #838

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

lukepmccombs
Copy link
Contributor

Adds check_cycle to __getstate__ and __setstate__ so that python copy and deepcopy should be exact duplicates of the original objects.
Expands the digraph copy and deepcopy tests to include check_cycle tests and python object instance tests.

Should resolve #836.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 18, 2023

Pull Request Test Coverage Report for Build 4463400819

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.157%

Totals Coverage Status
Change from base Build 4417477467: 0.02%
Covered Lines: 14048
Relevant Lines: 14459

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to add the release notes for the bugfix and it should be good to go

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Mar 20, 2023
@IvanIsCoding IvanIsCoding added this to the 0.13.0 milestone Mar 20, 2023
@mergify mergify bot merged commit 34cfa59 into Qiskit:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python copy does not replicate PyDiGraph.copy()
4 participants