-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all deprecation warnings in Rust and Upload actions #821
Conversation
Pull Request Test Coverage Report for Build 4379252718
💛 - Coveralls |
This is failing until #820 is merged (as any PR, really) but should be good to go |
@@ -77,12 +75,10 @@ jobs: | |||
python-version: ${{ matrix.python-version }} | |||
architecture: ${{ matrix.platform.python-architecture }} | |||
- name: Install Rust toolchain | |||
uses: actions-rs/toolchain@v1 | |||
uses: dtolnay/rust-toolchain@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this master
while other jobs use stable
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this Github action is a little bit funny because you can specify the version in the @
. @stable
installs Rust stable, @1.57.1
installs 1.57.1 etc. But if you want to have the version as an input (like from the matrix we have), the author suggests using the toolchain
field: https://github.com/dtolnay/rust-toolchain#inputs
#401 added a new step using the old Github action so I need to update that |
Closes #719
We switch the Github Actions to install Rust as
actions-rs/toolchain
is unmaintained (actions-rs/toolchain#221)We also bump
upload-artifact
tov3
, fixing all the remaining warnings