Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bfs_predecessors #819

Merged
merged 12 commits into from
Apr 6, 2023
Merged

add bfs_predecessors #819

merged 12 commits into from
Apr 6, 2023

Conversation

ewinston
Copy link
Contributor

This adds a bfs_predecessors method to complement bfs_successors.

@coveralls
Copy link

coveralls commented Feb 22, 2023

Pull Request Test Coverage Report for Build 4619289530

  • 69 of 79 (87.34%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 97.072%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/iterators.rs 35 45 77.78%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 1 98.88%
src/shortest_path/all_pairs_dijkstra.rs 1 98.54%
Totals Coverage Status
Change from base Build 4580675812: -0.07%
Covered Lines: 14092
Relevant Lines: 14517

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, it's pretty straightforward just a copy of the bfs_successors code with the direction reversed. I left one inline comment about an improvement we can make (which is also something we should do to bfs_successors).

Besides that the only thing that I think is missing is a release note for the new function.

src/traversal/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, thanks for the updates. I just left an inline suggestion on the release note text. Also I just noticed bfs_predecessors is not in the api documentation, it just needs to be added in: https://github.com/Qiskit/rustworkx/blob/main/docs/source/api.rst to the traversal section.

ewinston and others added 2 commits March 28, 2023 12:11
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the updates.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Apr 5, 2023
@mtreinish mtreinish removed the automerge Queue a approved PR for merging label Apr 6, 2023
@mtreinish mtreinish merged commit 1821aec into Qiskit:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants