-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bfs_predecessors #819
add bfs_predecessors #819
Conversation
Pull Request Test Coverage Report for Build 4619289530
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, it's pretty straightforward just a copy of the bfs_successors
code with the direction reversed. I left one inline comment about an improvement we can make (which is also something we should do to bfs_successors
).
Besides that the only thing that I think is missing is a release note for the new function.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now, thanks for the updates. I just left an inline suggestion on the release note text. Also I just noticed bfs_predecessors
is not in the api documentation, it just needs to be added in: https://github.com/Qiskit/rustworkx/blob/main/docs/source/api.rst to the traversal section.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the updates.
This adds a bfs_predecessors method to complement bfs_successors.