Simplifying betweenness_centrality (for vertices) #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlapeyre
force-pushed
the
cleanup-centrality
branch
from
23064c5
to
13d892c
Compare
Pull Request Test Coverage Report for Build 4388571347
💛 - Coveralls |
jlapeyre
force-pushed
the
cleanup-centrality
branch
from
cef796e
to
4d66ed6
Compare
jlapeyre
changed the title
mtreinish
approved these changes
Mar 10, 2023
| @@ -75,7 +74,7 @@ use rayon_cond::CondIterator; | |||
| /// [`edge_betweenness_centrality`] | |||
| pub fn betweenness_centrality<G>( | |||
| graph: G, | |||
| endpoints: bool, | |||
| include_endpoints: bool, | |||
There was a problem hiding this comment.
I think this ok from a backwards compatibility perspective since in rust the arguments are all passed positionally (this would be breaking in Python so I wanted to just note this and check myself).
There was a problem hiding this comment.
Oh yeah, that's a good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#799 "Add edge betweenness centrality" spurred me to try to reduce code repetition and complexity in betweenness centrality (for vertices). I recall trying
rayon-condin the past. In any case, it seems to work here now.