Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move find_cycle to rustworkx-core #789

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Move find_cycle to rustworkx-core #789

merged 1 commit into from
Jan 25, 2023

Conversation

enavarro51
Copy link
Contributor

This PR moves the function find_cycle from src/connectivity/mod.rs to rustworkx-core/connectivity/find_cycle.rs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3998835124

  • 55 of 58 (94.83%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 96.949%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/connectivity/find_cycle.rs 50 53 94.34%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 1 98.88%
Totals Coverage Status
Change from base Build 3969523438: 0.003%
Covered Lines: 13759
Relevant Lines: 14192
💛 - Coveralls

IvanIsCoding
IvanIsCoding approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jan 25, 2023
@mergify mergify bot merged commit c65830c into Qiskit:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enavarro51 @coveralls @IvanIsCoding