Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move barbell_graph generator to rustworkx-core #783

Merged
merged 10 commits into from
Jan 13, 2023

Conversation

enavarro51
Copy link
Contributor

his PR migrates the barbell_graph generator to rustwokx-core. It's based on #758.

@coveralls
Copy link

coveralls commented Jan 12, 2023

Pull Request Test Coverage Report for Build 3912640099

  • 90 of 102 (88.24%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 96.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/generators/barbell_graph.rs 67 79 84.81%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 1 99.27%
rustworkx-core/src/min_scored.rs 9 59.09%
Totals Coverage Status
Change from base Build 3903903204: -0.1%
Covered Lines: 13691
Relevant Lines: 14126

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found why your docstrings were failing

@@ -1456,6 +1455,12 @@ pub fn generalized_petersen_graph(
/// :class:`~rustworkx.PyGraph` object will not be not be a multigraph and
/// won't allow parallel edges to be added. Instead
/// calls which would create a parallel edge will update the existing edge.
/// :param list mesh_weights - A list of node weights for the mesh graph. If both
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// :param list mesh_weights - A list of node weights for the mesh graph. If both
/// :param list mesh_weights: A list of node weights for the mesh graph. If both

/// :param list mesh_weights - A list of node weights for the mesh graph. If both
/// ``num_mesh_nodes`` and ``mesh_weights`` are set ``num_mesh_nodes`` will
/// be ignored and ``mesh_weights`` will be used.
/// :param list path_weights - A list of node weights for the path. If both
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// :param list path_weights - A list of node weights for the path. If both
/// :param list path_weights: A list of node weights for the path. If both

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jan 13, 2023
@mergify mergify bot merged commit 7e559fd into Qiskit:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants