Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move heavy_square_graph generator to rustworkx-core #778

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Move heavy_square_graph generator to rustworkx-core #778

merged 4 commits into from
Jan 11, 2023

Conversation

enavarro51
Copy link
Contributor

@enavarro51 enavarro51 commented Jan 10, 2023 •
edited

This PR migrates the heavy_square_graph generator to rustwokx-core. It's based on #758.

There was a bug in the rustworkx undirected version of the heavy_square_graph, which created a different ordering in the edges from the directed version. The undirected tests were changed to fix it.

@mtreinish mtreinish added this to the 0.13.0 milestone Jan 11, 2023
@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jan 11, 2023
IvanIsCoding
IvanIsCoding approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for splitting the work into manageable pieces

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3895514114

  • 145 of 150 (96.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 97.044%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators.rs 8 10 80.0%
rustworkx-core/src/generators/heavy_square_graph.rs 137 140 97.86%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 2 98.88%
Totals Coverage Status
Change from base Build 3895251873: 0.02%
Covered Lines: 13493
Relevant Lines: 13904
💛 - Coveralls

@mergify mergify bot merged commit 1685d72 into Qiskit:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enavarro51 @coveralls @IvanIsCoding @mtreinish