Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hexagonal_lattice_graph generator to rustworkx-core #775

Merged
merged 10 commits into from
Jan 11, 2023
Merged

Move hexagonal_lattice_graph generator to rustworkx-core #775

merged 10 commits into from
Jan 11, 2023

Conversation

enavarro51
Copy link
Contributor

@enavarro51 enavarro51 commented Jan 7, 2023 •
edited

This PR migrates the hexagonal_lattice_graph generator to rustwokx-core. It's based on #758.

@coveralls
Copy link

coveralls commented Jan 8, 2023 •
edited

Pull Request Test Coverage Report for Build 3896031216

  • 119 of 122 (97.54%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 97.007%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/generators/hexagonal_lattice_graph.rs 98 99 98.99%
src/generators.rs 21 23 91.3%
Totals Coverage Status
Change from base Build 3895802236: -0.04%
Covered Lines: 13288
Relevant Lines: 13698
💛 - Coveralls

@mtreinish mtreinish added this to the 0.13.0 milestone Jan 11, 2023
IvanIsCoding
IvanIsCoding approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more LGTM

@IvanIsCoding IvanIsCoding merged commit c165a13 into Qiskit:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enavarro51 @coveralls @IvanIsCoding @mtreinish