Fix compatibility with priority-queue 1.3.0 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In priority-queue 1.3.0 compilation of rustworkx-core's min_cut module will fail because of the lack of a semicolon on the change_priority_by() call. This wasn't an issue with priority-queue 1.2.0 and for rustworkx development we are using priority-queue 1.2.0 because the priority queue 1.3.0 requires a rust version newer than our msrv. However, adding a semicolon to fix this compilation issue is also still compatibile with priority-queue 1.2.0. This commit does that to fix compatibility with newer versions of rustworkx-core that want to leverage the latest version of priority queue where they don't have the same MSRV constraints as rustworkx. Fixes Qiskit#744
mtreinish
added
the
stable-backport-potential
Pull Request Test Coverage Report for Build 3518129383
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
In priority-queue 1.3.0 compilation of rustworkx-core's min_cut module will fail because of the lack of a semicolon on the change_priority_by() call. This wasn't an issue with priority-queue 1.2.0 and for rustworkx development we are using priority-queue 1.2.0 because the priority queue 1.3.0 requires a rust version newer than our msrv. However, adding a semicolon to fix this compilation issue is also still compatibile with priority-queue 1.2.0. This commit does that to fix compatibility with newer versions of rustworkx-core that want to leverage the latest version of priority queue where they don't have the same MSRV constraints as rustworkx. Fixes #744 (cherry picked from commit 46a8799)
mergify bot
added a commit
that referenced
this pull request
Nov 21, 2022
In priority-queue 1.3.0 compilation of rustworkx-core's min_cut module will fail because of the lack of a semicolon on the change_priority_by() call. This wasn't an issue with priority-queue 1.2.0 and for rustworkx development we are using priority-queue 1.2.0 because the priority queue 1.3.0 requires a rust version newer than our msrv. However, adding a semicolon to fix this compilation issue is also still compatibile with priority-queue 1.2.0. This commit does that to fix compatibility with newer versions of rustworkx-core that want to leverage the latest version of priority queue where they don't have the same MSRV constraints as rustworkx. Fixes #744 (cherry picked from commit 46a8799) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In priority-queue 1.3.0 compilation of rustworkx-core's min_cut module will fail because of the lack of a semicolon on the change_priority_by() call. This wasn't an issue with priority-queue 1.2.0 and for rustworkx development we are using priority-queue 1.2.0 because the priority queue 1.3.0 requires a rust version newer than our msrv. However, adding a semicolon to fix this compilation issue is also still compatibile with priority-queue 1.2.0. This commit does that to fix compatibility with newer versions of rustworkx-core that want to leverage the latest version of priority queue where they don't have the same MSRV constraints as rustworkx.
Fixes #744