Bump MSRV to 1.56.1 and update dependencies and Rust Edition #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous minimum support Rust version of 1.48 was originally selected to match the latest version of Rust available through Debian stable. This was done primarily to support the piwheels build environemnt which installs rustc via Debian packages. However, the 1.48 MSRV is causing a lot development friction as it's quite old and is holding back a lot of dependencies. When weighing the relatively tiny piwheels user base (for an unsupported platform) against this it's probably time to decouple our MSRV for rustworkx from that and pick a version that makes the most sense for our development needs. This commit raises the minimum supported rust version to 1.56.1 and then bumps all our dependencies held back because of the previous MSRV. At the same time the rust edition used for rustworkx is changed to be edition 2021 instead of edition 2018. This will enable us to leverage newer rust syntax now. Fixes Qiskit#716
Pull Request Test Coverage Report for Build 3342211914
💛 - Coveralls |
IvanIsCoding
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous minimum support Rust version of 1.48 was originally selected to match the latest version of Rust available through Debian stable. This was done primarily to support the piwheels build environemnt which installs rustc via Debian packages. However, the 1.48 MSRV is causing a lot development friction as it's quite old and is holding back a lot of dependencies. When weighing the relatively tiny piwheels user base (for an unsupported platform) against this it's probably time to decouple our MSRV for rustworkx from that and pick a version that makes the most sense for our development needs.
This commit raises the minimum supported rust version to 1.56.1 and then bumps all our dependencies held back because of the previous MSRV. At the same time the rust edition used for rustworkx is changed to be edition 2021 instead of edition 2018. This will enable us to leverage newer rust syntax now.
Fixes #716