-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyO3 to 0.17.2 #702
Conversation
Pull Request Test Coverage Report for Build 3274874854
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I had a branch doing this for 0.17.0 but was blocked on some breaking changes. It's good to see that 0.17.2 fixed those.
We should test to see if #696 is fixed by this or if we can fix it now that we're on the newer version. If so we can backport this for 0.12.1
I think I can write the tests covering the use case and make a PR by end of the week. Hopefully they pass straight away |
* Update pyo3 * Clippy + Cargo fmt * Add clippy warning that was removed (cherry picked from commit c073a21)
* Update pyo3 * Clippy + Cargo fmt * Add clippy warning that was removed (cherry picked from commit c073a21) Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps PyO3 and NumPy to 0.17.2
It has been a while since dependabot has sent us updates notifications for PyO3 and we missed a couple. But I think bumping to 0.17.2 should work fine given the Rust MSRV is still the same and we have released 0.12