Introduce build.rs to reduce boilerplate
#1253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9939690792Details
💛 - Coveralls |
IvanIsCoding
changed the title
build.rs to reduce boilerplatebuild.rs to reduce boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1252
Real diff: IvanIsCoding/rustworkx@smarter-boilerplate...IvanIsCoding:rustworkx:build-rs
This PR leverages
build.rsto reduce even more the boilerplate required to add a newrustworkxfunction. All needed now is to addmod your_module;to the main file after addingexport_rustworkx_functions!to the new module.I don't think we can generate multiple
mod a; mod b;statments in Rust due to the limitations ofinclude!. Still, I think this is worth keeping to make contributing more straightforward with some "magic".