Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SciPy as a development dependency #1221

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

IvanIsCoding
Copy link
Collaborator

This PR removes SciPy as a development dependency. Instead of relying on NetworkX's new implementation based on SciPy, this introduced forked code from NetworkX's old pure Python implementation.

I added NetworkX's BSD-3 license at the top of the files. We have already done similar for the visualization module in the past.

Partially motivated by #1220. But it is nice to test the hits and pagerank methods in architectures that previously skipped the test before

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9590028523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 95.844%

Files with Coverage Reduction New Missed Lines %
src/iterators.rs 3 75.15%
Totals Coverage Status
Change from base Build 9589302565: -0.02%
Covered Lines: 17410
Relevant Lines: 18165

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, I like removing scipy as a test dependency, just a comment inline about the exceptions.

tests/digraph/test_hits.py Outdated Show resolved Hide resolved
tests/digraph/test_pagerank.py Outdated Show resolved Hide resolved
@mtreinish mtreinish added this to the 0.15.0 milestone Jun 21, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jun 21, 2024
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9620377450

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 95.863%

Files with Coverage Reduction New Missed Lines %
src/iterators.rs 3 75.89%
Totals Coverage Status
Change from base Build 9620375454: -0.02%
Covered Lines: 17589
Relevant Lines: 18348

💛 - Coveralls

@mtreinish mtreinish merged commit 097e90c into Qiskit:main Jun 21, 2024
28 of 30 checks passed
@IvanIsCoding IvanIsCoding deleted the remove-scipy-dev-dep branch June 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants