Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coveralls by changing the extension to .lcov #1198

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix coveralls by changing the extension to .lcov #1198

merged 2 commits into from
May 22, 2024

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented May 21, 2024 •
edited

I have no idea why but our Coveralls integration started complaining about lcov files with .info, so I switched to .lcov

@IvanIsCoding IvanIsCoding marked this pull request as draft May 21, 2024 13:00
@IvanIsCoding IvanIsCoding changed the title Use coveralls format from grcov [WIP] Use coveralls format from grcov May 21, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9183064992

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.508%
Totals Coverage Status
Change from base Build 9139666696: 0.03%
Covered Lines: 16750
Relevant Lines: 17356
💛 - Coveralls

@IvanIsCoding IvanIsCoding changed the title [WIP] Use coveralls format from grcov Fix coveralls by changing the extension to .lcov May 22, 2024
@IvanIsCoding IvanIsCoding marked this pull request as ready for review May 22, 2024 00:21
mtreinish
mtreinish approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I'm surprised the action cares about the file extension now, but this has fixed the job so let's go with it.

@mtreinish mtreinish merged commit 1df925d into Qiskit:main May 22, 2024
28 of 29 checks passed
@IvanIsCoding IvanIsCoding deleted the fix-coveralls-ci branch June 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvanIsCoding @coveralls @mtreinish