Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial kwargs in mpl_draw #1180

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Allow partial kwargs in mpl_draw #1180

merged 2 commits into from
Apr 30, 2024

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #1179

We missed https://typing.readthedocs.io/en/latest/spec/typeddict.html#totality. Because total=True is the default, mypy and other type checkers expect all arguments which is not user-friendly.

mtreinish
mtreinish approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Apr 30, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8894576978

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.521%
Totals Coverage Status
Change from base Build 8887516283: 0.0%
Covered Lines: 17338
Relevant Lines: 17963
💛 - Coveralls

@IvanIsCoding IvanIsCoding merged commit cc2c396 into Qiskit:main Apr 30, 2024
28 of 30 checks passed
@IvanIsCoding IvanIsCoding deleted the fix-mpl-draw-typing branch April 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpl_draw requires all keyword arguments to be specified to pass mypy
3 participants
@IvanIsCoding @coveralls @mtreinish