Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using macos-latest for jobs we want x86_64 macOS #1175

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mtreinish
Copy link
Member

Github actions recently changed the macos-latest runner to use macos-14, which changes the CI environment to run with arm64 instead of x86_64. This has several impacts on our test jobs where the intent was to specifically test native x86_64 macOS. This commit changes the ci configuration to use macos-13 in places where this was the case, as we were already explicitly using macos-14 where we wanted arm64 runners.

Github actions recently changed the macos-latest runner to use macos-14,
which changes the CI environment to run with arm64 instead of x86_64.
This has several impacts on our test jobs where the intent was to
specifically test native x86_64 macOS. This commit changes the ci
configuration to use macos-13 in places where this was the case, as we
were already explicitly using macos-14 where we wanted arm64 runners.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8819642348

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.494%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 6 95.53%
Totals Coverage Status
Change from base Build 8728616448: -0.03%
Covered Lines: 17314
Relevant Lines: 17943

💛 - Coveralls

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Apr 24, 2024
@mtreinish mtreinish merged commit 229f38f into Qiskit:main Apr 24, 2024
28 checks passed
@mtreinish mtreinish deleted the x86-macos-runner branch April 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants