Allow TopologicalSorter without error checking
#1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimises the creation of the `list` objects returned from `TopologicalSorter.get_ready` (by avoiding a temporary `Vec`) and allows `done` to accept a single index, avoiding the need for the user to allocate many small lists in several real-world uses.
For representative examples in Qiskit, this reduces the runtime of interacting with the topological sorter by around 15-20%.
jakelishman
force-pushed
the
toposort-check-args
branch
from
2774414
to
becd5bc
Compare
Pull Request Test Coverage Report for Build 8639062108Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For representative examples in Qiskit, this reduces the runtime of interacting with the topological sorter by around 15-20%.
Built on top of #1159. This is the dynamic-check version of #1158.
Close #1158.
Using the same timings as #1159, but adding
check_args=False, the same test drops to 233µs for me, which is another 15% (though I've seen more in other graphs). There is maybe a 1% hit for the newOptionchecking ofnode2statein thecheck_args=Truecase, but that might just have been statistical noise on my machine.