Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support GraphML support for long #1142

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Adds support GraphML support for long #1142

merged 3 commits into from
Mar 16, 2024

Conversation

jamesdbaker
Copy link
Contributor

Fixes #1140 by adding GraphML support for "long", along with corresponding unit tests

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@IvanIsCoding
Copy link
Collaborator

Thanks so much for finding the bug AND contributing the fix! Overall the code seems ready and the unit test is appropriate.

I think the only missing item is the CLA signing and then we should be good to go

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8298916674

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.48%

Totals Coverage Status
Change from base Build 8210134916: 0.0%
Covered Lines: 17160
Relevant Lines: 17786

💛 - Coveralls

@IvanIsCoding IvanIsCoding added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Mar 16, 2024
@IvanIsCoding IvanIsCoding merged commit b5ac124 into Qiskit:main Mar 16, 2024
28 checks passed
mergify bot pushed a commit that referenced this pull request Mar 16, 2024
* Add support for long in GraphML

* Formatting changes

* Add details to Release Note

(cherry picked from commit b5ac124)
IvanIsCoding pushed a commit that referenced this pull request Mar 16, 2024
* Add support for long in GraphML

* Formatting changes

* Add details to Release Note

(cherry picked from commit b5ac124)

Co-authored-by: jamesdbaker <james.d.baker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "long" attribute type in GraphML
4 participants