Fix panic error at shortest paths #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8207084623Details
💛 - Coveralls |
IvanIsCoding
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Thanks for contributing this! The tests LGTM and so do the error messages. I did propose a simpler method to check if a node is present, though.
Also, you would mind expanding the fix to the Bellman-Ford and A* implementations? They are conceptually similar to Dijkstra's and were not included in the bug report. But they also panic now I believe
src/shortest_path/mod.rs
Outdated
Comment on lines
80
to
84
| if !graph | ||
| .node_indices() | ||
| .nodes | ||
| .iter() | ||
| .any(|&node| node == source) |
There was a problem hiding this comment.
I think we can simplify this to:
Suggested change
| if !graph | |
| .node_indices() | |
| .nodes | |
| .iter() | |
| .any(|&node| node == source) | |
| if !graph.graph.contains_node(start) |
There was a problem hiding this comment.
Note that you will need to move the if statement after the variable is defined
There was a problem hiding this comment.
Thanks, i really appreciate it the feedback, i gonna make the changes
src/shortest_path/mod.rs
Outdated
| if !graph | ||
| .node_indices() | ||
| .nodes | ||
| .iter() | ||
| .any(|&index| index == node) | ||
| { | ||
| return Err(PyIndexError::new_err(format!( | ||
| "Node source index \"{node}\" out of graph bound" | ||
| ))); | ||
| } | ||
|
|
src/shortest_path/mod.rs
Outdated
Comment on lines
475
to
480
| if !graph | ||
| .node_indices() | ||
| .nodes | ||
| .iter() | ||
| .any(|&index| index == node) | ||
| { |
src/shortest_path/mod.rs
Outdated
Comment on lines
230
to
234
| if !graph | ||
| .node_indices() | ||
| .nodes | ||
| .iter() | ||
| .any(|&node| node == source) |
JPena-code
changed the title
IvanIsCoding
approved these changes
Mar 8, 2024
IvanIsCoding
added
the
stable-backport-potential
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* lint suggestion UP032 * Test of dijkstra raising IndexError * Test Bellman Ford and A* * fix: shortest path (cherry picked from commit 058b0c7)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1117 is presented the presence of an uncaught
pyo3.PanicExceptionwhen the index of the source node is no out of bound in the graph. With this naive approach i try fix this issue raising a more understandableIndexError.