-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing musl skip for ppc64le builds #1109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the ppc64le wheel builds. One of the two ppc64le wheel build jobs was incorrectly attempting to build wheels for musl environments which isn't a supported platform and the jobs failed to configure. This commit just adds the missing skip for those environments to the job configuration to fix this issue.
Pull Request Test Coverage Report for Build 8005147455Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this should work as I tested it in #1064
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
This commit fixes an issue in the ppc64le wheel builds. One of the two ppc64le wheel build jobs was incorrectly attempting to build wheels for musl environments which isn't a supported platform and the jobs failed to configure. This commit just adds the missing skip for those environments to the job configuration to fix this issue. Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> (cherry picked from commit f4f1212)
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Feb 22, 2024
This commit prepares for a 0.14.1 release which just includes Qiskit#1109 to fix ppc64le builds and Qiskit#1096 to fix the overhead of `__getitem__` on custom sequence return types.
Merged
mergify bot
added a commit
that referenced
this pull request
Feb 22, 2024
This commit fixes an issue in the ppc64le wheel builds. One of the two ppc64le wheel build jobs was incorrectly attempting to build wheels for musl environments which isn't a supported platform and the jobs failed to configure. This commit just adds the missing skip for those environments to the job configuration to fix this issue. Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> (cherry picked from commit f4f1212) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
added a commit
that referenced
this pull request
Feb 22, 2024
* Prepare 0.14.1 release This commit prepares for a 0.14.1 release which just includes #1109 to fix ppc64le builds and #1096 to fix the overhead of `__getitem__` on custom sequence return types. * Update releasenotes/notes/prepare-0.14.1-e5065553a44eb035.yaml Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> * Update version in docs config too --------- Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Queue a approved PR for merging
stable-backport-potential
This PR or issue is potentially worth backporting for inclusion in a stable branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in the ppc64le wheel builds. One of the two ppc64le wheel build jobs was incorrectly attempting to build wheels for musl environments which isn't a supported platform and the jobs failed to configure. This commit just adds the missing skip for those environments to the job configuration to fix this issue.