Add reverse argument to topological sorters
#1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `lexicographical_topological_sort` and `TopologicalSorter` to produce a topological sort that would have been found if the edges in the graph had reversed directions, without constructing the edge-flipped graph. This is useful for graphs where we might want to do topological analysis from both ends of the data flow, for example in Qiskit where we occasionally want to find the "final" operations topologically.
Pull Request Test Coverage Report for Build 8116939754Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Feb 25, 2024
src/dag_algo/mod.rs
Outdated
Comment on lines
377
to
381
| let (in_dir, out_dir) = if reverse { | ||
| (petgraph::Direction::Outgoing, petgraph::Direction::Incoming) | ||
| } else { | ||
| (petgraph::Direction::Incoming, petgraph::Direction::Outgoing) | ||
| }; |
There was a problem hiding this comment.
Can you create a public function in dag_algo to encapsulate this logic and reuse it in the other files? It is a nitpick but just to avoid the kind of bugs where we flip it
|
Sorry for disappearing for a while there. I've added the helper in 12a91ec. |
IvanIsCoding
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
lexicographical_topological_sortandTopologicalSorterto produce a topological sort that would have been found if the edges in the graph had reversed directions, without constructing the edge-flipped graph.This is useful for graphs where we might want to do topological analysis from both ends of the data flow, for example in Qiskit where we occasionally want to find the "final" operations topologically.
Close #1105