Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects need to explicitly opt-in to Qiskit ecosystem #622

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

We realized it's incorrect to be saying that every project that uses this theme is a part of the Qiskit ecosystem. Any project can use this theme, even projects that have nothing to do with quantum computing.

However, we do still want to include the link to the ecosystem for relevant projects because it's a) good branding for the partners and b) drives traffic to the ecosystem.

We decided you should opt-in to the sidebar option, rather than opt-out. We'd rather have false negatives than false positives (showing the URL when it shouldn't be).

Default:

Screenshot 2024-08-21 at 3 34 48 PM

With option set:

Screenshot 2024-08-21 at 3 35 11 PM

Copy link
Collaborator

@kevinsung kevinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

example_docs/docs/conf.py Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano merged commit 2e94899 into Qiskit:main Aug 22, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/opt-in-to-ecosystem branch August 22, 2024 14:08
Eric-Arellano added a commit that referenced this pull request Aug 22, 2024
We realized it's incorrect to be saying that every project that uses
this theme is a part of the Qiskit ecosystem. Any project can use this
theme, even projects that have nothing to do with quantum computing.

However, we do still want to include the link to the ecosystem for
relevant projects because it's a) good branding for the partners and b)
drives traffic to the ecosystem.

We decided you should opt-in to the sidebar option, rather than opt-out.
We'd rather have false negatives than false positives (showing the URL
when it shouldn't be).

Default:

<img width="289" alt="Screenshot 2024-08-21 at 3 34 48 PM"
src="https://github.com/user-attachments/assets/fa952dde-054e-40ae-857a-ad653ab06ac8">

With option set:

<img width="289" alt="Screenshot 2024-08-21 at 3 35 11 PM"
src="https://github.com/user-attachments/assets/30d5e6d4-0d55-48c1-81ba-4eaadc82ff33">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants