404 thebe #354
Merged
404 thebe #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit_sphinx_theme/__init__.py
Outdated
Comment on lines
41
to
46
| if not doctree or doctree.traverse(ThebeButtonNode): | ||
| thebe_js_files = ["_static/sphinx-thebe.js", "_static/thebelab-helper.js", "https://unpkg.com/thebelab@latest/lib/index.js"] | ||
| context["script_files"] = [js_file for js_file in context["script_files"] if js_file not in thebe_js_files] | ||
|
|
||
| thebe_css_files = ['_static/thebelab.css', '_static/sphinx-thebe.css'] | ||
| context["css_files"] = [css_file for css_file in context["css_files"] if css_file not in thebe_css_files] |
There was a problem hiding this comment.
You need to early return if the condition is True.
Suggested change
| if not doctree or doctree.traverse(ThebeButtonNode): | |
| thebe_js_files = ["_static/sphinx-thebe.js", "_static/thebelab-helper.js", "https://unpkg.com/thebelab@latest/lib/index.js"] | |
| context["script_files"] = [js_file for js_file in context["script_files"] if js_file not in thebe_js_files] | |
| thebe_css_files = ['_static/thebelab.css', '_static/sphinx-thebe.css'] | |
| context["css_files"] = [css_file for css_file in context["css_files"] if css_file not in thebe_css_files] | |
| if not doctree or doctree.traverse(ThebeButtonNode): | |
| return | |
| thebe_js_files = ["_static/sphinx-thebe.js", "_static/thebelab-helper.js", "https://unpkg.com/thebelab@latest/lib/index.js"] | |
| context["script_files"] = [js_file for js_file in context["script_files"] if js_file not in thebe_js_files] | |
| thebe_css_files = ['_static/thebelab.css', '_static/sphinx-thebe.css'] | |
| context["css_files"] = [css_file for css_file in context["css_files"] if css_file not in thebe_css_files] |
qiskit_sphinx_theme/__init__.py
Outdated
| @@ -50,6 +73,7 @@ def setup(app): | |||
| _overwrite_pygments_css, | |||
| ) | |||
|
|
|||
|
|
|||
qiskit_sphinx_theme/__init__.py
Outdated
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| from qiskit_sphinx_theme import directives, previous_releases, translations | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
When opening a pull request, it's a good practice to look in GitHub at the diff. Are you making any changes you didn't realize? This is a good example of one. There's no reason to be adding these blank lines here. I suspect it was leftover from when you were iterating on the code.
Suggested change
Eric-Arellano
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #291