Fix regression of code links being blue #336
Conversation
Closes Qiskit#335. I git bisected this to Qiskit#292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Closes #335. I git bisected this to #292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
|
sorry I didn't jump on this sooner but just wanted to add some context. For web accessibility there is a lot of debate around the best way to style hyperlinks. I think previously it was considered best practice to ensure all hyperlinks are underlined and specifically blue in colour for unvisited links and purple for visited. This could explain why older versions of this codebase manually changed the link colours like that. I think more recently this best practice has been relaxed a bit (i think partly because web tech has become more creative and design-led) and the latest WCAG guidance just specifies that the colour needs to be a specific contrast ratio, and different colours for hover/visited links are optional: https://www.w3.org/TR/2016/NOTE-UNDERSTANDING-WCAG20-20161007/understanding-techniques.html |
Closes #335.
I git bisected this to #292. Before, we weren't actually fully running
theme.jsbecause JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class.has-code, but after they did. I suspecttheme.jsis responsible for that (but I couldn't figure out how!)Either way, these rules about
.has-codeare bad. We should not be setting links to be blue.