Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase language selector visibility #23

Conversation

delapuente
Copy link
Contributor

Fixes Qiskit/qiskit.org#1364

The PR tries to mitigate the lack of visibility of the language selector reported in Qiskit/qiskit.org#1364 Although the selector is not sticky, it is better now in a more visible location.

For wide screens:
Collapsed selector is now on the top left area, stacked on the TOC

Expanded selector shows the different language options

For mobile screens:
The collapsed selector stacks on top of the collapsed TOC

The expanded selector push the rest of the content down

@delapuente
Copy link
Contributor Author

@SooluThomas maybe you want to take a look at it and review.

Copy link
Member

@SooluThomas SooluThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you

@nonhermitian nonhermitian self-requested a review February 17, 2021 15:01
Copy link
Contributor

@nonhermitian nonhermitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is nice.

@nonhermitian nonhermitian merged commit 5b0bda1 into Qiskit:main Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise the visibility of the translated docs
3 participants