Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command/Inst refactor: Pulses and Play #3936

Merged
merged 49 commits into from
Mar 25, 2020
Merged

Command/Inst refactor: Pulses and Play #3936

merged 49 commits into from
Mar 25, 2020

Commits on Mar 6, 2020

  1. Deprecate PulseCommands, create new Play Instruction-implementation. … 

    …The Play instruction takes a Pulse and a PulseChannel. Pulse is a new class within the pulse library that is very close to the deprecated PulseCommand abstract class. The PulseCommand implementations (SamplePulse and the ParametricPulse subclasses) have been moved to the pulse library as well, subclassing from Pulse, and all valid arguments to Play.
    @lcapelluto
    lcapelluto committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    5ae572a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Update import statements in Pulse

    @lcapelluto
    lcapelluto committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3433240 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a007339 View commit details
    Browse the repository at this point in the history

  2. Fill in the implementation of some IP work like __call__

    @lcapelluto
    lcapelluto committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2a71ffa View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    ba918a6 View commit details
    Browse the repository at this point in the history

  2. Fill in and update documentation, complete import paths

    @lcapelluto
    lcapelluto committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    9bbc01f View commit details
    Browse the repository at this point in the history

  3. fixup cyclic imports

    @lcapelluto
    lcapelluto committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    c5b0741 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. IP updates to assemble_schedules for supporting Play instruction

    @lcapelluto
    lcapelluto committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    780e5f8 View commit details
    Browse the repository at this point in the history

  2. Give all pulses a name arg and update reno note

    @lcapelluto
    lcapelluto committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    d4418e3 View commit details
    Browse the repository at this point in the history

  3. Continue pulse_instruction conversion support for Play

    @lcapelluto
    lcapelluto committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    66d2a25 View commit details
    Browse the repository at this point in the history

  4. Add support for Play in assemble schedules, fix style

    @lcapelluto
    lcapelluto committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    646529c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    4bfe424 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Attempt to fix build error

    @lcapelluto
    lcapelluto committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    6104e88 View commit details
    Browse the repository at this point in the history

  2. Add missing name field to Constant pulse

    @lcapelluto
    lcapelluto committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    67ab1b4 View commit details
    Browse the repository at this point in the history

  3. To support __call__ from Pulse, I need to import Play, which means I … 

    …can't import Pulse from Play (for typehints) for the timebeing
    @lcapelluto
    lcapelluto committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    36134c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    b8f73e6 View commit details
    Browse the repository at this point in the history

  2. Fixup bugs introduced in SamplePulse

    @lcapelluto
    lcapelluto committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    efbbd17 View commit details
    Browse the repository at this point in the history

  3. Update tests with new API

    @lcapelluto
    lcapelluto committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    33c8da4 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Add tests and fixup missing name passing

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    8739997 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    f1ed9ed View commit details
    Browse the repository at this point in the history

  3. Fixup tests, remove deprecation warning from assemble execution, add … 

    …hash and eq methods to pulses
    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0bed2c2 View commit details
    Browse the repository at this point in the history

  4. Fixup docs

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    dc1d42d View commit details
    Browse the repository at this point in the history

  5. Update functional_pulse import path and Instruction type ref

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e7facb3 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    f719a86 View commit details
    Browse the repository at this point in the history

  7. try again with the type hints

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    cbefe8a View commit details
    Browse the repository at this point in the history

  8. Was missing updates to PulseCommand that needed to be migrated with t… 

    …he new Pulse class
    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    98169f3 View commit details
    Browse the repository at this point in the history

  9. Was missing docstring type documentation for unresolvable type

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    74ada9b View commit details
    Browse the repository at this point in the history

  10. Was missing removal of PulseStyle in parametric pulses

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a889e47 View commit details
    Browse the repository at this point in the history

  11. The changes from the sphinx warrnings pass hadn't been moved with the… 

    … migrated ParametricPulses module. Moved the drag pulse docstring over finally
    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    16278c0 View commit details
    Browse the repository at this point in the history

  12. Fix spacing in drag pulse docstring

    @lcapelluto
    lcapelluto committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    14fc973 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. The docs should finally build now

    @lcapelluto
    lcapelluto committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    3d9efd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Update qiskit/pulse/instructions/play.py 

    Co-Authored-By: eggerdj <38065505+eggerdj@users.noreply.github.com>
    @lcapelluto @eggerdj
    lcapelluto and eggerdj authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    d753a45 View commit details
    Browse the repository at this point in the history

  2. Update qiskit/pulse/pulse_lib/sample_pulse.py 

    Co-Authored-By: eggerdj <38065505+eggerdj@users.noreply.github.com>
    @lcapelluto @eggerdj
    lcapelluto and eggerdj authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    e05c937 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-Authored-By: eggerdj <38065505+eggerdj@users.noreply.github.com>
    @lcapelluto @eggerdj
    lcapelluto and eggerdj authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    30a517d View commit details
    Browse the repository at this point in the history

  4. Documentation improvements

    @lcapelluto
    lcapelluto committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    c2ecd3d View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into issue-3750-pulses

    @lcapelluto
    lcapelluto committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    4fe635d View commit details
    Browse the repository at this point in the history

  6. Test change because linux python35 is failing

    @lcapelluto
    lcapelluto committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8430aec View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Update releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8… 

    …a29d3.yaml

Co-Authored-By: eggerdj <38065505+eggerdj@users.noreply.github.com>
    @lcapelluto @eggerdj
    lcapelluto and eggerdj authored Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c1c64a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-3750-pulses

    @lcapelluto
    lcapelluto authored Mar 24, 2020
    Configuration menu
    Copy the full SHA
    1abc77c View commit details
    Browse the repository at this point in the history

  3. Fix plotting Play instruction

    @lcapelluto
    lcapelluto committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    85988f2 View commit details
    Browse the repository at this point in the history

  4. style, line length

    @lcapelluto
    lcapelluto committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    dcc4c90 View commit details
    Browse the repository at this point in the history

  5. Attempt to fix failing test by comparing names directly

    @lcapelluto
    lcapelluto committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    5d1fb84 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Handle all instruction types in add_instruction

    @lcapelluto
    lcapelluto committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    873e5a1 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @lcapelluto
    lcapelluto committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    2c73613 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue-3750-pulses

    @lcapelluto
    lcapelluto authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    e53f42e View commit details
    Browse the repository at this point in the history

  4. Update releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8… 

    …a29d3.yaml

Co-Authored-By: Matthew Treinish <mtreinish@kortar.org>
    @lcapelluto @mtreinish
    lcapelluto and mtreinish authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    e41082a View commit details
    Browse the repository at this point in the history

  5. Separate note about Play feature into two notes: Play feature and Pul… 

    …se movement
    @lcapelluto
    lcapelluto committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    0e0c142 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'issue-3750-pulses' of github.com:lcapelluto/qiskit-terr… 

    …a into issue-3750-pulses
    @lcapelluto
    lcapelluto committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    8de5dfb View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into issue-3750-pulses

    @mergify
    mergify[bot] authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c654bd3 View commit details
    Browse the repository at this point in the history