Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings with latest clippy #12919

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

jakelishman
Copy link
Member

Summary

These aren't failing CI, which uses clippy at MSRV, they're just triggered by more recent versions.

Details and comments

These aren't failing CI, which uses `clippy` at MSRV, they're just
triggered by more recent versions.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository labels Aug 8, 2024
@jakelishman jakelishman added this to the 1.2.0 milestone Aug 8, 2024
@jakelishman jakelishman requested a review from a team as a code owner August 8, 2024 00:08
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @mtreinish

@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10297352724

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.743%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/target_transpiler/nullable_index_map.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.39%
crates/qasm2/src/lex.rs 3 92.73%
crates/qasm2/src/parse.rs 6 97.61%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 7 90.84%
Totals Coverage Status
Change from base Build 10294759406: -0.01%
Covered Lines: 67325
Relevant Lines: 75020

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Aug 8, 2024
@mtreinish mtreinish removed the stable backport potential The bug might be minimal and/or import enough to be port to stable label Aug 8, 2024
@mtreinish mtreinish modified the milestones: 1.2.0, 1.3 beta Aug 8, 2024
@mtreinish
Copy link
Member

I removed the stable backport tag here because the target rust code does not exist in stable/1.2 it was merged on main for 1.3.

@jakelishman
Copy link
Member Author

Oh yeah thanks, I forgot about that.

Merged via the queue into Qiskit:main with commit 154601b Aug 8, 2024
15 checks passed
@jakelishman jakelishman deleted the clippy-1.80 branch August 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants