Enable ROCm target based on existing CUDA/Thrust implementation. #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport/cuda-refactor
…pport/cuda-refactor
…ment requirement used by State data.
doichanj
added
the
Changelog: New Feature
This reverts commit f07234e.
|
I believe the docs parsing issues have been fixed in the last update. @doichanj, let me know your thoughts. |
doichanj
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Please remove prelude section from release note.
Could you add similar explanation how to build from source for AMD GPU in CONTRIBUTING.md ?
Add ROCm build instructions.
doichanj
reviewed
Sep 1, 2023
|
@doichanj, yes, it was designed to be as little disruptive as possible for ports of already existing CUDA implementations. I added the Contribution.md changes in the last commit. Let me know if you'd like to include more there. |
doichanj
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable ROCm target based on existing CUDA/Thrust implementation.
Changelog: New Feature
Details and comments
Add the
AER_THURST_ROCMto signal the a ROCm target is desired. Build system changes included to select specific GPU targets and leverage CMake support for HIP. The porting approach uses macro replacement to match CUDA runtime calls with their HIP counterparts. There is an assumption being made that the wavefronts/warps have all threads active, expanding that assumption to the ROCm implementation that uses a wider wave-front.