Unify all platforms with CMake #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dsvensson
commented
Aug 7, 2024
•
dsvensson
commented
- Same build system as mvdsv and ktx, polished IDE integrations.
- Same build system on all platforms. No more XML diffs for Visual Studio project.
- Generation of Xcode and Visual Studio projects that work with profiler etc.
- Cross-compilation with mingw for i686/x64, including building of all deps.
- Static builds first class on Windows/Linux/macOS, no need to consider what versions are in distros.
- Sandboxed client on macOS, no risk of leaking filesystem content due to exploits.
- A much more capable build system that makes it easier to deal with future improvements.
dsvensson
force-pushed
the
cmake
branch
2 times, most recently
from
fcdcace
to
c0d55b7
Compare
dsvensson
commented
Aug 7, 2024
dsvensson
commented
Aug 7, 2024
dsvensson
force-pushed
the
cmake
branch
13 times, most recently
from
a59b650
to
e940a79
Compare
|
@tcsabina @qqshka @ciscon This is mostly done by now except for updating CI, old CI still uploading stuff. Maybe some readme stuff left, maybe some bikeshedding here and there, probably some stuff I'm blind to. Read it, try it so we can get it merged. Could also merge as is and update CI after merge as this PR will not delete any of the old ways of building. |
The reasoning for the recent changes were based on non-macOS users questions in the helpdesk channel on Discord. On macOS the OS deals with the gamma changes very smoothly so this isn't really an issue.
Switch raw input to GameController which is made to work with sandboxed applications. When the application starts, the user is prompted with a file dialog that allows selection of what basedir to use. This will be stored in the application preferences for future launches. When the directory becomes unavailable, or a new version is installed, the user will be prompted with the file dialog again.
dsvensson
force-pushed
the
cmake
branch
2 times, most recently
from
0e339ae
to
fcaa969
Compare
dsvensson
force-pushed
the
cmake
branch
5 times, most recently
from
cf3e86c
to
0a9a891
Compare
dsvensson
force-pushed
the
cmake
branch
3 times, most recently
from
a77c545
to
74e2487
Compare
* Build fixes for PCRE2 on macOS. * New minor versions of SDL2, zlib. * Makes SDL_DBUS optional on Linux, cutting 85% build time.
dsvensson
force-pushed
the
cmake
branch
4 times, most recently
from
f010117
to
90bc542
Compare
dsvensson
force-pushed
the
cmake
branch
2 times, most recently
from
aa337f2
to
b32b1ae
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.